From: Juerg Billeter <j@bitron.ch>
Date: Wed, 30 Jan 2008 16:29:25 +0000 (+0000)
Subject: report error when trying to add instance fields to interfaces, fixes bug
X-Git-Tag: VALA_0_1_7~162
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=adc1ab218f101374babe8b19662d57bd70ca14f4;p=platform%2Fupstream%2Fvala.git

report error when trying to add instance fields to interfaces, fixes bug

2008-01-30  Juerg Billeter  <j@bitron.ch>

	* vala/valasemanticanalyzer.vala: report error when trying to add
	  instance fields to interfaces, fixes bug 513152

svn path=/trunk/; revision=929
---

diff --git a/ChangeLog b/ChangeLog
index a3f99f9..eae93c1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-01-30  Jürg Billeter  <j@bitron.ch>
 
+	* vala/valasemanticanalyzer.vala: report error when trying to add
+	  instance fields to interfaces, fixes bug 513152
+
+2008-01-30  Jürg Billeter  <j@bitron.ch>
+
 	* vala/valainterfacewriter.vala: output # for properties transferring
 	  ownership
 
diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala
index 2e9e539..806f611 100644
--- a/vala/valasemanticanalyzer.vala
+++ b/vala/valasemanticanalyzer.vala
@@ -316,6 +316,12 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
 	public override void visit_field (Field! f) {
 		f.accept_children (this);
 
+		if (f.instance && f.parent_symbol is Interface) {
+			f.error = true;
+			Report.error (f.source_reference, "Interfaces may not have instance fields");
+			return;
+		}
+
 		if (!f.is_internal_symbol ()) {
 			current_source_file.add_type_dependency (f.type_reference, SourceFileDependencyType.HEADER_SHALLOW);
 		} else {