From: Alessandro Decina <alessandro.d@gmail.com>
Date: Sun, 15 May 2011 08:00:44 +0000 (+0200)
Subject: hls: fix handling of strol() overflows
X-Git-Tag: 1.19.3~507^2~16050^2~253
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=adc0817b2a5ebb513b3a6fa130ceec4c50b6dfc9;p=platform%2Fupstream%2Fgstreamer.git

hls: fix handling of strol() overflows
---

diff --git a/gst/hls/m3u8.c b/gst/hls/m3u8.c
index cb6bf59..20252f0 100644
--- a/gst/hls/m3u8.c
+++ b/gst/hls/m3u8.c
@@ -104,21 +104,29 @@ static gboolean
 int_from_string (gchar * ptr, gchar ** endptr, gint * val)
 {
   gchar *end;
+  glong ret;
 
   g_return_val_if_fail (ptr != NULL, FALSE);
   g_return_val_if_fail (val != NULL, FALSE);
 
   errno = 0;
-  *val = strtol (ptr, &end, 10);
-  if ((errno == ERANGE && (*val == LONG_MAX || *val == LONG_MIN))
-      || (errno != 0 && *val == 0)) {
+  ret = strtol (ptr, &end, 10);
+  if ((errno == ERANGE && (ret == LONG_MAX || ret == LONG_MIN))
+      || (errno != 0 && ret == 0)) {
     GST_WARNING ("%s", g_strerror (errno));
     return FALSE;
   }
 
+  if (ret > G_MAXINT) {
+    GST_WARNING ("%s", g_strerror (ERANGE));
+    return FALSE;
+  }
+
   if (endptr)
     *endptr = end;
 
+  *val = (gint) ret;
+
   return end != ptr;
 }