From: Michal Kazior Date: Thu, 4 Sep 2014 10:36:45 +0000 (+0200) Subject: ath10k: fix debugfs_create_dir() checking X-Git-Tag: v4.9.8~5202^2~28^2~90^2~82 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=adb43b24ec12a008656dcca831ab835a94261963;p=platform%2Fkernel%2Flinux-rpi3.git ath10k: fix debugfs_create_dir() checking The function may return an -ENODEV if debugfs is disabled in kernel. This should originally be guarded by ath10k's Kconfig but it still makes sense to check for the non-NULL errno return value. Reported-by: Matteo Croce Signed-off-by: Michal Kazior Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index c5d0105..c192114 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -1176,8 +1176,12 @@ int ath10k_debug_register(struct ath10k *ar) { ar->debug.debugfs_phy = debugfs_create_dir("ath10k", ar->hw->wiphy->debugfsdir); - if (!ar->debug.debugfs_phy) - return -ENOMEM; + if (IS_ERR_OR_NULL(ar->debug.debugfs_phy)) { + if (IS_ERR(ar->debug.debugfs_phy)) + return PTR_ERR(ar->debug.debugfs_phy); + else + return -ENOMEM; + } INIT_DELAYED_WORK(&ar->debug.htt_stats_dwork, ath10k_debug_htt_stats_dwork);