From: Javier Martinez Canillas Date: Tue, 29 Sep 2015 11:26:07 +0000 (+0200) Subject: mfd: da9052: Simplify function return logic X-Git-Tag: v4.14-rc1~4390^2~29 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ad698ea425f90e4d09694c2cf7155cad4d7badb3;p=platform%2Fkernel%2Flinux-rpi.git mfd: da9052: Simplify function return logic The invoked functions already return zero on success or a negative errno code so there is no need to open code the logic in the caller. Signed-off-by: Javier Martinez Canillas Acked-by: Adam Thomson Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c index 0288700..2697ffb 100644 --- a/drivers/mfd/da9052-i2c.c +++ b/drivers/mfd/da9052-i2c.c @@ -174,11 +174,7 @@ static int da9052_i2c_probe(struct i2c_client *client, return ret; } - ret = da9052_device_init(da9052, id->driver_data); - if (ret != 0) - return ret; - - return 0; + return da9052_device_init(da9052, id->driver_data); } static int da9052_i2c_remove(struct i2c_client *client) diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c index b5de8a6..0f5e2c2 100644 --- a/drivers/mfd/da9052-spi.c +++ b/drivers/mfd/da9052-spi.c @@ -56,11 +56,7 @@ static int da9052_spi_probe(struct spi_device *spi) return ret; } - ret = da9052_device_init(da9052, id->driver_data); - if (ret != 0) - return ret; - - return 0; + return da9052_device_init(da9052, id->driver_data); } static int da9052_spi_remove(struct spi_device *spi)