From: Roel Kluin <roel.kluin@gmail.com>
Date: Sun, 3 Jan 2010 17:04:42 +0000 (-0300)
Subject: V4L/DVB (12930): Wrong variable tested
X-Git-Tag: v2.6.34-rc1~280^2~272
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ad695510bf27a4e73e0d04d48d80c0b8389f17d2;p=platform%2Fkernel%2Flinux-stable.git

V4L/DVB (12930): Wrong variable tested

The return of saa7164_i2caddr_to_reglen() was not tested.

Cc: Steven Toth <stoth@kernellabs.com>
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/saa7164/saa7164-api.c b/drivers/media/video/saa7164/saa7164-api.c
index 6f094a9..1d487c1 100644
--- a/drivers/media/video/saa7164/saa7164-api.c
+++ b/drivers/media/video/saa7164/saa7164-api.c
@@ -523,7 +523,7 @@ int saa7164_api_i2c_write(struct saa7164_i2c *bus, u8 addr, u32 datalen,
 	}
 
 	reglen = saa7164_i2caddr_to_reglen(bus, addr);
-	if (unitid < 0) {
+	if (reglen < 0) {
 		printk(KERN_ERR
 			"%s() error, cannot translate regaddr to reglen\n",
 			__func__);