From: Daniel Stenberg <daniel@haxx.se>
Date: Thu, 16 Feb 2006 10:02:11 +0000 (+0000)
Subject: Added some clarifying comments
X-Git-Tag: upstream/7.37.1~10521
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ad6511c313a06a62421e1b426974cf8b5e85f466;p=platform%2Fupstream%2Fcurl.git

Added some clarifying comments
---

diff --git a/lib/url.c b/lib/url.c
index 49e7c1c..fe0dc3c 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -2296,7 +2296,8 @@ static void fix_hostname(struct connectdata *conn, struct hostname *host)
  *
  * @param data The sessionhandle pointer
  * @param in_connect is set to the next connection data pointer
- * @param addr is set to the new dns entry for this connection
+ * @param addr is set to the new dns entry for this connection. If this
+ *        connection is re-used it will be NULL.
  * @param async is set TRUE/FALSE depending on the nature of this lookup
  * @return CURLcode
  * @see SetupConnection()
@@ -3630,8 +3631,11 @@ static CURLcode CreateConnection(struct SessionHandle *data,
   return result;
 }
 
-/* SetupConnection() should be called after the name resolve initiated in
+/* SetupConnection() is called after the name resolve initiated in
  * CreateConnection() is all done.
+ *
+ * NOTE: the argument 'hostaddr' is NULL when this function is called for a
+ * re-used connection.
  */
 
 static CURLcode SetupConnection(struct connectdata *conn,
@@ -3730,8 +3734,8 @@ CURLcode Curl_connect(struct SessionHandle *data,
     /* no error */
     if(dns || !*asyncp)
       /* If an address is available it means that we already have the name
-         resolved, OR it isn't async.
-         If so => continue connecting from here */
+         resolved, OR it isn't async. if this is a re-used connection 'dns'
+         will be NULL here. Continue connecting from here */
       code = SetupConnection(*in_connect, dns, protocol_done);
     /* else
          response will be received and treated async wise */