From: Mehdi Amini Date: Sat, 2 Apr 2016 05:07:53 +0000 (+0000) Subject: Create a typedef GlobalValue::GUID for uint64_t and RAUW (NFC) X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ad5741b075518e840d4ef55bffe3e3cbf41c370b;p=platform%2Fupstream%2Fllvm.git Create a typedef GlobalValue::GUID for uint64_t and RAUW (NFC) Summary: This should make the code more readable, especially all the map declarations. Reviewers: tejohnson Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D18721 From: Mehdi Amini llvm-svn: 265215 --- diff --git a/llvm/include/llvm/IR/GlobalValue.h b/llvm/include/llvm/IR/GlobalValue.h index c6a88e4..987d748 100644 --- a/llvm/include/llvm/IR/GlobalValue.h +++ b/llvm/include/llvm/IR/GlobalValue.h @@ -320,13 +320,18 @@ public: /// used as the key for a global lookup (e.g. profile or ThinLTO). std::string getGlobalIdentifier(); + /// Declare a type to represent a global unique identifier for a global value. + /// This is a 64 bits hash that is used by PGO and ThinLTO to have a compact + /// unique way to identify a symbol. + using GUID = uint64_t; + /// Return a 64-bit global unique ID constructed from global value name /// (i.e. returned by getGlobalIdentifier()). - static uint64_t getGUID(StringRef GlobalName) { return MD5Hash(GlobalName); } + static GUID getGUID(StringRef GlobalName) { return MD5Hash(GlobalName); } /// Return a 64-bit global unique ID constructed from global value name /// (i.e. returned by getGlobalIdentifier()). - uint64_t getGUID() { return getGUID(getGlobalIdentifier()); } + GUID getGUID() { return getGUID(getGlobalIdentifier()); } /// @name Materialization /// Materialization is used to construct functions only as they're needed. diff --git a/llvm/include/llvm/IR/ModuleSummaryIndex.h b/llvm/include/llvm/IR/ModuleSummaryIndex.h index fe0385e..b4240e7 100644 --- a/llvm/include/llvm/IR/ModuleSummaryIndex.h +++ b/llvm/include/llvm/IR/ModuleSummaryIndex.h @@ -82,7 +82,7 @@ private: /// (either by the initializer of a global variable, or referenced /// from within a function). This does not include functions called, which /// are listed in the derived FunctionSummary object. - std::vector RefEdgeList; + std::vector RefEdgeList; protected: /// GlobalValueSummary constructor. @@ -107,7 +107,7 @@ public: /// Record a reference from this global value to the global value identified /// by \p RefGUID. - void addRefEdge(uint64_t RefGUID) { RefEdgeList.push_back(RefGUID); } + void addRefEdge(GlobalValue::GUID RefGUID) { RefEdgeList.push_back(RefGUID); } /// Record a reference from this global value to each global value identified /// in \p RefEdges. @@ -117,8 +117,8 @@ public: } /// Return the list of GUIDs referenced by this global value definition. - std::vector &refs() { return RefEdgeList; } - const std::vector &refs() const { return RefEdgeList; } + std::vector &refs() { return RefEdgeList; } + const std::vector &refs() const { return RefEdgeList; } }; /// \brief Function summary information to aid decisions and implementation of @@ -126,7 +126,7 @@ public: class FunctionSummary : public GlobalValueSummary { public: /// call edge pair. - typedef std::pair EdgeTy; + typedef std::pair EdgeTy; private: /// Number of instructions (ignoring debug instructions, e.g.) computed @@ -152,7 +152,7 @@ public: /// Record a call graph edge from this function to the function identified /// by \p CalleeGUID, with \p CalleeInfo including the cumulative profile /// count (across all calls from this function) or 0 if no PGO. - void addCallGraphEdge(uint64_t CalleeGUID, CalleeInfo Info) { + void addCallGraphEdge(GlobalValue::GUID CalleeGUID, CalleeInfo Info) { CallGraphEdgeList.push_back(std::make_pair(CalleeGUID, Info)); } @@ -243,7 +243,7 @@ typedef std::vector> GlobalValueInfoList; /// less overhead, as the value type is not very small and the size /// of the map is unknown, resulting in inefficiencies due to repeated /// insertions and resizing. -typedef std::map GlobalValueInfoMapTy; +typedef std::map GlobalValueInfoMapTy; /// Type used for iterating through the global value info map. typedef GlobalValueInfoMapTy::const_iterator const_globalvalueinfo_iterator; @@ -293,7 +293,7 @@ public: /// Get the list of global value info objects for a given value GUID. const const_globalvalueinfo_iterator - findGlobalValueInfoList(uint64_t ValueGUID) const { + findGlobalValueInfoList(GlobalValue::GUID ValueGUID) const { return GlobalValueMap.find(ValueGUID); } @@ -304,7 +304,7 @@ public: } /// Add a global value info for a value of the given GUID. - void addGlobalValueInfo(uint64_t ValueGUID, + void addGlobalValueInfo(GlobalValue::GUID ValueGUID, std::unique_ptr Info) { GlobalValueMap[ValueGUID].push_back(std::move(Info)); } diff --git a/llvm/include/llvm/Transforms/IPO/FunctionImport.h b/llvm/include/llvm/Transforms/IPO/FunctionImport.h index ac6dd27..da792f5 100644 --- a/llvm/include/llvm/Transforms/IPO/FunctionImport.h +++ b/llvm/include/llvm/Transforms/IPO/FunctionImport.h @@ -11,6 +11,7 @@ #define LLVM_FUNCTIONIMPORT_H #include "llvm/ADT/StringMap.h" +#include "llvm/IR/GlobalValue.h" #include #include @@ -29,7 +30,7 @@ public: /// containing all the functions to import for a source module. /// The keys is the GUID identifying a function to import, and the value /// is the threshold applied when deciding to import it. - typedef std::map FunctionsToImportTy; + typedef std::map FunctionsToImportTy; /// The map contains an entry for every module to import from, the key being /// the module identifier to pass to the ModuleLoader. The value is the set of @@ -37,7 +38,7 @@ public: typedef StringMap ImportMapTy; /// The set contains an entry for every global value the module exports. - typedef std::unordered_set ExportSetTy; + typedef std::unordered_set ExportSetTy; /// Create a Function Importer. FunctionImporter( diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index 4543596..3598deb 100644 --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -446,7 +446,7 @@ class ModuleSummaryIndexBitcodeReader { // call graph edges read from the function summary from referencing // callees by their ValueId to using the GUID instead, which is how // they are recorded in the summary index being built. - DenseMap ValueIdToCallGraphGUIDMap; + DenseMap ValueIdToCallGraphGUIDMap; /// Map to save the association between summary offset in the VST to the /// GlobalValueInfo object created when parsing it. Used to access the @@ -502,7 +502,7 @@ private: std::error_code initStream(std::unique_ptr Streamer); std::error_code initStreamFromBuffer(); std::error_code initLazyStream(std::unique_ptr Streamer); - uint64_t getGUIDFromValueId(unsigned ValueId); + GlobalValue::GUID getGUIDFromValueId(unsigned ValueId); GlobalValueInfo *getInfoFromSummaryOffset(uint64_t Offset); }; } // end anonymous namespace @@ -5444,7 +5444,8 @@ void ModuleSummaryIndexBitcodeReader::freeState() { Buffer = nullptr; } void ModuleSummaryIndexBitcodeReader::releaseBuffer() { Buffer.release(); } -uint64_t ModuleSummaryIndexBitcodeReader::getGUIDFromValueId(unsigned ValueId) { +GlobalValue::GUID +ModuleSummaryIndexBitcodeReader::getGUIDFromValueId(unsigned ValueId) { auto VGI = ValueIdToCallGraphGUIDMap.find(ValueId); assert(VGI != ValueIdToCallGraphGUIDMap.end()); return VGI->second; @@ -5540,7 +5541,7 @@ std::error_code ModuleSummaryIndexBitcodeReader::parseValueSymbolTable( // VST_CODE_COMBINED_GVDEFENTRY: [valueid, offset, guid] unsigned ValueID = Record[0]; uint64_t GlobalValSummaryOffset = Record[1]; - uint64_t GlobalValGUID = Record[2]; + GlobalValue::GUID GlobalValGUID = Record[2]; std::unique_ptr GlobalValInfo = llvm::make_unique(GlobalValSummaryOffset); SummaryOffsetToInfoMap[GlobalValSummaryOffset] = GlobalValInfo.get(); @@ -5551,7 +5552,7 @@ std::error_code ModuleSummaryIndexBitcodeReader::parseValueSymbolTable( case bitc::VST_CODE_COMBINED_ENTRY: { // VST_CODE_COMBINED_ENTRY: [valueid, refguid] unsigned ValueID = Record[0]; - uint64_t RefGUID = Record[1]; + GlobalValue::GUID RefGUID = Record[1]; ValueIdToCallGraphGUIDMap[ValueID] = RefGUID; break; } @@ -5787,7 +5788,7 @@ std::error_code ModuleSummaryIndexBitcodeReader::parseEntireSummary() { "Record size inconsistent with number of references"); for (unsigned I = 4, E = CallGraphEdgeStartIndex; I != E; ++I) { unsigned RefValueId = Record[I]; - uint64_t RefGUID = getGUIDFromValueId(RefValueId); + GlobalValue::GUID RefGUID = getGUIDFromValueId(RefValueId); FS->addRefEdge(RefGUID); } bool HasProfile = (BitCode == bitc::FS_PERMODULE_PROFILE); @@ -5796,11 +5797,11 @@ std::error_code ModuleSummaryIndexBitcodeReader::parseEntireSummary() { unsigned CalleeValueId = Record[I]; unsigned CallsiteCount = Record[++I]; uint64_t ProfileCount = HasProfile ? Record[++I] : 0; - uint64_t CalleeGUID = getGUIDFromValueId(CalleeValueId); + GlobalValue::GUID CalleeGUID = getGUIDFromValueId(CalleeValueId); FS->addCallGraphEdge(CalleeGUID, CalleeInfo(CallsiteCount, ProfileCount)); } - uint64_t GUID = getGUIDFromValueId(ValueID); + GlobalValue::GUID GUID = getGUIDFromValueId(ValueID); auto InfoList = TheIndex->findGlobalValueInfoList(GUID); assert(InfoList != TheIndex->end() && "Expected VST parse to create GlobalValueInfo entry"); @@ -5821,10 +5822,10 @@ std::error_code ModuleSummaryIndexBitcodeReader::parseEntireSummary() { TheIndex->addModulePath(Buffer->getBufferIdentifier(), 0)->first()); for (unsigned I = 2, E = Record.size(); I != E; ++I) { unsigned RefValueId = Record[I]; - uint64_t RefGUID = getGUIDFromValueId(RefValueId); + GlobalValue::GUID RefGUID = getGUIDFromValueId(RefValueId); FS->addRefEdge(RefGUID); } - uint64_t GUID = getGUIDFromValueId(ValueID); + GlobalValue::GUID GUID = getGUIDFromValueId(ValueID); auto InfoList = TheIndex->findGlobalValueInfoList(GUID); assert(InfoList != TheIndex->end() && "Expected VST parse to create GlobalValueInfo entry"); @@ -5855,7 +5856,7 @@ std::error_code ModuleSummaryIndexBitcodeReader::parseEntireSummary() { "Record size inconsistent with number of references"); for (unsigned I = 4, E = CallGraphEdgeStartIndex; I != E; ++I) { unsigned RefValueId = Record[I]; - uint64_t RefGUID = getGUIDFromValueId(RefValueId); + GlobalValue::GUID RefGUID = getGUIDFromValueId(RefValueId); FS->addRefEdge(RefGUID); } bool HasProfile = (BitCode == bitc::FS_COMBINED_PROFILE); @@ -5864,7 +5865,7 @@ std::error_code ModuleSummaryIndexBitcodeReader::parseEntireSummary() { unsigned CalleeValueId = Record[I]; unsigned CallsiteCount = Record[++I]; uint64_t ProfileCount = HasProfile ? Record[++I] : 0; - uint64_t CalleeGUID = getGUIDFromValueId(CalleeValueId); + GlobalValue::GUID CalleeGUID = getGUIDFromValueId(CalleeValueId); FS->addCallGraphEdge(CalleeGUID, CalleeInfo(CallsiteCount, ProfileCount)); } @@ -5883,7 +5884,7 @@ std::error_code ModuleSummaryIndexBitcodeReader::parseEntireSummary() { FS->setModulePath(ModuleIdMap[ModuleId]); for (unsigned I = 2, E = Record.size(); I != E; ++I) { unsigned RefValueId = Record[I]; - uint64_t RefGUID = getGUIDFromValueId(RefValueId); + GlobalValue::GUID RefGUID = getGUIDFromValueId(RefValueId); FS->addRefEdge(RefGUID); } auto *Info = getInfoFromSummaryOffset(CurRecordBit); diff --git a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp index 84bdd8c..4ee53b5 100644 --- a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp +++ b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp @@ -2397,11 +2397,10 @@ static void WriteValueSymbolTable( /// Emit function names and summary offsets for the combined index /// used by ThinLTO. -static void -WriteCombinedValueSymbolTable(const ModuleSummaryIndex &Index, - BitstreamWriter &Stream, - std::map &GUIDToValueIdMap, - uint64_t VSTOffsetPlaceholder) { +static void WriteCombinedValueSymbolTable( + const ModuleSummaryIndex &Index, BitstreamWriter &Stream, + std::map &GUIDToValueIdMap, + uint64_t VSTOffsetPlaceholder) { assert(VSTOffsetPlaceholder > 0 && "Expected non-zero VSTOffsetPlaceholder"); // Get the offset of the VST we are writing, and backpatch it into // the VST forward declaration record. @@ -2427,7 +2426,7 @@ WriteCombinedValueSymbolTable(const ModuleSummaryIndex &Index, SmallVector NameVals; for (const auto &FII : Index) { - uint64_t FuncGUID = FII.first; + GlobalValue::GUID FuncGUID = FII.first; const auto &VMI = GUIDToValueIdMap.find(FuncGUID); assert(VMI != GUIDToValueIdMap.end()); @@ -3052,7 +3051,8 @@ static void WritePerModuleGlobalValueSummary( /// Emit the combined summary section into the combined index file. static void WriteCombinedGlobalValueSummary( const ModuleSummaryIndex &I, BitstreamWriter &Stream, - std::map &GUIDToValueIdMap, unsigned GlobalValueId) { + std::map &GUIDToValueIdMap, + unsigned GlobalValueId) { Stream.EnterSubblock(bitc::GLOBALVAL_SUMMARY_BLOCK_ID, 3); // Abbrev for FS_COMBINED. @@ -3445,7 +3445,7 @@ void llvm::WriteIndexToFile(const ModuleSummaryIndex &Index, raw_ostream &Out) { // in writing out the call graph edges. Save the mapping from GUID // to the new global value id to use when writing those edges, which // are currently saved in the index in terms of GUID. - std::map GUIDToValueIdMap; + std::map GUIDToValueIdMap; unsigned GlobalValueId = 0; for (auto &II : Index) GUIDToValueIdMap[II.first] = ++GlobalValueId; diff --git a/llvm/lib/IR/ModuleSummaryIndex.cpp b/llvm/lib/IR/ModuleSummaryIndex.cpp index c23e072..5effc65 100644 --- a/llvm/lib/IR/ModuleSummaryIndex.cpp +++ b/llvm/lib/IR/ModuleSummaryIndex.cpp @@ -23,7 +23,7 @@ void ModuleSummaryIndex::mergeFrom(std::unique_ptr Other, StringRef ModPath; for (auto &OtherGlobalValInfoLists : *Other) { - uint64_t ValueGUID = OtherGlobalValInfoLists.first; + GlobalValue::GUID ValueGUID = OtherGlobalValInfoLists.first; GlobalValueInfoList &List = OtherGlobalValInfoLists.second; // Assert that the value info list only has one entry, since we shouldn't diff --git a/llvm/lib/Transforms/IPO/FunctionImport.cpp b/llvm/lib/Transforms/IPO/FunctionImport.cpp index b5f1ffb..f69bc1d 100644 --- a/llvm/lib/Transforms/IPO/FunctionImport.cpp +++ b/llvm/lib/Transforms/IPO/FunctionImport.cpp @@ -103,7 +103,8 @@ selectCallee(const GlobalValueInfoList &CalleeInfoList, unsigned Threshold) { /// Return the summary for the function \p GUID that fits the \p Threshold, or /// null if there's no match. -static const FunctionSummary *selectCallee(uint64_t GUID, unsigned Threshold, +static const FunctionSummary *selectCallee(GlobalValue::GUID GUID, + unsigned Threshold, const ModuleSummaryIndex &Index) { auto CalleeInfoList = Index.findGlobalValueInfoList(GUID); if (CalleeInfoList == Index.end()) { @@ -114,7 +115,8 @@ static const FunctionSummary *selectCallee(uint64_t GUID, unsigned Threshold, /// Return true if the global \p GUID is exported by module \p ExportModulePath. static bool isGlobalExported(const ModuleSummaryIndex &Index, - StringRef ExportModulePath, uint64_t GUID) { + StringRef ExportModulePath, + GlobalValue::GUID GUID) { auto CalleeInfoList = Index.findGlobalValueInfoList(GUID); if (CalleeInfoList == Index.end()) // This global does not have a summary, it is not part of the ThinLTO @@ -138,7 +140,7 @@ using EdgeInfo = std::pair; static void computeImportForFunction( StringRef ModulePath, const FunctionSummary &Summary, const ModuleSummaryIndex &Index, unsigned Threshold, - const std::map &DefinedFunctions, + const std::map &DefinedFunctions, SmallVectorImpl &Worklist, FunctionImporter::ImportMapTy &ImportsForModule, StringMap &ExportLists) { @@ -198,7 +200,7 @@ static void computeImportForFunction( /// another module (that may require promotion). static void ComputeImportForModule( StringRef ModulePath, - const std::map &DefinedFunctions, + const std::map &DefinedFunctions, const ModuleSummaryIndex &Index, FunctionImporter::ImportMapTy &ImportsForModule, StringMap &ExportLists) { @@ -242,8 +244,8 @@ void llvm::ComputeCrossModuleImport( // Collect for each module the list of function it defines. // GUID -> Summary - StringMap> Module2FunctionInfoMap( - ModuleCount); + StringMap> + Module2FunctionInfoMap(ModuleCount); for (auto &GlobalList : Index) { auto GUID = GlobalList.first;