From: Pierre-Louis Bossart Date: Tue, 17 Mar 2020 16:33:26 +0000 (-0500) Subject: soundwire: cadence: remove automatic command retries X-Git-Tag: v5.15~4157^2~25^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ad473db4ec8d5502e35d78a034a92a520afb9964;p=platform%2Fkernel%2Flinux-starfive.git soundwire: cadence: remove automatic command retries This is a good idea on paper, but it's not recommended at all when operating in multi-master mode. It's also not recommended when doing bank switches, since the retransmission would happen at the next SSP, and the command protocol is stuck in the mean time. Signed-off-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20200317163329.25501-15-pierre-louis.bossart@linux.intel.com Signed-off-by: Vinod Koul --- diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index 420ad23..c9fdd4d 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -1109,8 +1109,7 @@ int sdw_cdns_init(struct sdw_cdns *cdns) /* leave frame delay to hardware default of 0x1F */ - /* Set Max cmd retry to 15 */ - val |= CDNS_MCP_CONFIG_MCMD_RETRY; + /* leave command retry to hardware default of 0 */ cdns_writel(cdns, CDNS_MCP_CONFIG, val);