From: Miklos Szeredi Date: Fri, 9 Nov 2018 14:52:16 +0000 (+0100) Subject: fuse: fix leaked notify reply X-Git-Tag: v3.18.126~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ace9067ef64f29d84584155d575f87067d9f1604;p=profile%2Fwearable%2Fplatform%2Fkernel%2Flinux-3.18-exynos7270.git fuse: fix leaked notify reply commit 7fabaf303458fcabb694999d6fa772cc13d4e217 upstream. fuse_request_send_notify_reply() may fail if the connection was reset for some reason (e.g. fs was unmounted). Don't leak request reference in this case. Besides leaking memory, this resulted in fc->num_waiting not being decremented and hence fuse_wait_aborted() left in a hanging and unkillable state. Fixes: 2d45ba381a74 ("fuse: add retrieve request") Fixes: b8f95e5d13f5 ("fuse: umount should wait for all requests") Reported-and-tested-by: syzbot+6339eda9cb4ebbc4c37b@syzkaller.appspotmail.com Signed-off-by: Miklos Szeredi Cc: #v2.6.36 Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 0834f56..0560de4 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -1675,8 +1675,10 @@ static int fuse_retrieve(struct fuse_conn *fc, struct inode *inode, req->in.args[1].size = total_len; err = fuse_request_send_notify_reply(fc, req, outarg->notify_unique); - if (err) + if (err) { fuse_retrieve_end(fc, req); + fuse_put_request(fc, req); + } return err; }