From: Christophe JAILLET Date: Sun, 9 Jan 2022 12:29:45 +0000 (+0100) Subject: i2c: ismt: Remove useless DMA-32 fallback configuration X-Git-Tag: v6.6.17~6503^2~31 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=acaa07e5dde76b9c762b4d8f00ad5b3901edb7ff;p=platform%2Fkernel%2Flinux-rpi.git i2c: ismt: Remove useless DMA-32 fallback configuration As stated in [1], dma_set_mask() with a 64-bit mask never fails if dev->dma_mask is non-NULL. So, if it fails, the 32 bits case will also fail for the same reason. Simplify code and remove some dead code accordingly. [1]: https://lkml.org/lkml/2021/6/7/398 Signed-off-by: Christophe JAILLET Reviewed-by: Seth Heasley Signed-off-by: Wolfram Sang --- diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c index 6078fa0..fe23495 100644 --- a/drivers/i2c/busses/i2c-ismt.c +++ b/drivers/i2c/busses/i2c-ismt.c @@ -937,11 +937,8 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id) err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (err) { - err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); - if (err) { - dev_err(&pdev->dev, "dma_set_mask fail\n"); - return -ENODEV; - } + dev_err(&pdev->dev, "dma_set_mask fail\n"); + return -ENODEV; } err = ismt_dev_init(priv);