From: Hannes Reinecke Date: Tue, 27 Apr 2021 08:30:37 +0000 (+0200) Subject: scsi: advansys: Do not set message byte in SCSI status X-Git-Tag: accepted/tizen/unified/20230118.172025~6832^2~133^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ac87ee0ac120119f52cfc8e5fce696d8fc84dbb4;p=platform%2Fkernel%2Flinux-rpi.git scsi: advansys: Do not set message byte in SCSI status The host byte in the SCSI status takes precedence during error recovery, so there is no point in setting the message byte in addition to a host byte which is not DID_OK. Link: https://lore.kernel.org/r/20210427083046.31620-32-hare@suse.de Signed-off-by: Hannes Reinecke Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 379ff1b..f3377e2 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -6728,14 +6728,12 @@ static void asc_isr_callback(ASC_DVC_VAR *asc_dvc_varp, ASC_QDONE_INFO *qdonep) case QD_ABORTED_BY_HOST: ASC_DBG(1, "QD_ABORTED_BY_HOST\n"); set_status_byte(scp, qdonep->d3.scsi_stat); - set_msg_byte(scp, qdonep->d3.scsi_msg); set_host_byte(scp, DID_ABORT); break; default: ASC_DBG(1, "done_stat 0x%x\n", qdonep->d3.done_stat); set_status_byte(scp, qdonep->d3.scsi_stat); - set_msg_byte(scp, qdonep->d3.scsi_msg); set_host_byte(scp, DID_ERROR); break; }