From: Sebastian Dröge <sebastian@centricular.com>
Date: Thu, 19 Jan 2017 12:24:07 +0000 (+0200)
Subject: rtsp-client: Fix handling of keep-alive GET_PARAMETER/SET_PARAMETER
X-Git-Tag: 1.19.3~495^2~432
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ac1124efb4e5e1cef2853628ba5cb46cdb30308d;p=platform%2Fupstream%2Fgstreamer.git

rtsp-client: Fix handling of keep-alive GET_PARAMETER/SET_PARAMETER

While they logically have 0 bytes length, GstRTSPConnection is appending
a '\0' to everything making the size be 1 instead.
---

diff --git a/gst/rtsp-server/rtsp-client.c b/gst/rtsp-server/rtsp-client.c
index 6f59c5e..63ac617 100644
--- a/gst/rtsp-server/rtsp-client.c
+++ b/gst/rtsp-server/rtsp-client.c
@@ -1250,8 +1250,8 @@ handle_get_param_request (GstRTSPClient * client, GstRTSPContext * ctx)
   if (res != GST_RTSP_OK)
     goto bad_request;
 
-  if (size == 0) {
-    /* no body, keep-alive request */
+  if (size == 1) {
+    /* no body (only '\0'), keep-alive request */
     send_generic_response (client, GST_RTSP_STS_OK, ctx);
   } else {
     /* there is a body, handle the params */
@@ -1302,8 +1302,8 @@ handle_set_param_request (GstRTSPClient * client, GstRTSPContext * ctx)
   if (res != GST_RTSP_OK)
     goto bad_request;
 
-  if (size == 0) {
-    /* no body, keep-alive request */
+  if (size == 1) {
+    /* no body (only '\0'), keep-alive request */
     send_generic_response (client, GST_RTSP_STS_OK, ctx);
   } else {
     /* there is a body, handle the params */