From: Brian Date: Thu, 1 Feb 2007 17:08:07 +0000 (-0700) Subject: comments X-Git-Tag: 062012170305~19731^2~285 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=abeca8d17d0728e68ec0c7cb9d9ca91b06b560d0;p=profile%2Fivi%2Fmesa.git comments --- diff --git a/src/mesa/swrast/s_span.c b/src/mesa/swrast/s_span.c index 5c552e6..4a56275 100644 --- a/src/mesa/swrast/s_span.c +++ b/src/mesa/swrast/s_span.c @@ -599,7 +599,6 @@ interpolate_texcoords(GLcontext *ctx, SWspan *span) q += dqdx; w += dwdx; } - } else { for (i = 0; i < span->end; i++) { @@ -817,7 +816,10 @@ interpolate_texcoords(GLcontext *ctx, SWspan *span) /** - * Fill in the span.varying array from the interpolation values. + * Fill in the arrays->attribs[FRAG_ATTRIB_VARx] arrays from the + * interpolation values. + * XXX since interpolants/arrays are getting uniformed, we might merge + * this with interpolate_texcoords(), interpolate_Fog(), etc. someday. */ static INLINE void interpolate_varying(GLcontext *ctx, SWspan *span) diff --git a/src/mesa/swrast/s_span.h b/src/mesa/swrast/s_span.h index 292679b..ff91768 100644 --- a/src/mesa/swrast/s_span.h +++ b/src/mesa/swrast/s_span.h @@ -81,6 +81,9 @@ struct arrays2 { typedef struct sw_span_arrays { /** Per-fragment attributes (indexed by FRAG_ATTRIB_* tokens) */ + /* XXX someday look at transposing first two indexes for better memory + * access pattern. + */ GLfloat attribs[FRAG_ATTRIB_MAX][MAX_WIDTH][4]; /** This mask indicates which fragments are alive or culled */