From: Ilho Kim Date: Fri, 5 Aug 2022 06:13:12 +0000 (+0900) Subject: Clear memory db before sending the finish signal X-Git-Tag: accepted/tizen/6.5/unified/20220808.135237~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=abbfe1553b28f688457f7dac74ac4868cb9ec7cb;p=platform%2Fcore%2Fappfw%2Fapp-installers.git Clear memory db before sending the finish signal Because installer can write to db during undo or clear operation such as UninstallSteps, the client who received the finish signal may take the wrong package information Change-Id: I62d674e4b37692fabdee45287c99dce202616b87 Signed-off-by: Ilho Kim (cherry picked from commit 6b1545db2a79c4fbfe9bc5a0d29ddce0a2d41d57) --- diff --git a/src/common/installer/app_installer.cc b/src/common/installer/app_installer.cc index 0f767c3..c4eb9b9 100644 --- a/src/common/installer/app_installer.cc +++ b/src/common/installer/app_installer.cc @@ -207,10 +207,8 @@ AppInstaller::Result AppInstaller::Run() { Process(); if (it_ != steps_.end() && result_ == Result::ERROR) { LOG(ERROR) << "Failure occurs in step: " << (*it_)->name(); - pkgmgr_parser_clear_cache_memory_db(); Undo(); } else { - pkgmgr_parser_clear_cache_memory_db(); Clean(); } sync(); @@ -872,6 +870,8 @@ void AppInstaller::SendProgress(int progress) { } void AppInstaller::SendFinished(Step::Status process_status) { + pkgmgr_parser_clear_cache_memory_db(); + if (!SendStartIfNotSent(false)) return;