From: Jakub Kicinski Date: Fri, 9 Jun 2017 03:56:10 +0000 (-0700) Subject: nfp: make sure to cancel port refresh on the error path X-Git-Tag: v4.13-rc1~157^2~240^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ab832b8de405c640d407b4473c6875210c326255;p=platform%2Fkernel%2Flinux-exynos.git nfp: make sure to cancel port refresh on the error path If very last stages of netdev registering and init fail some other netdevs and devlink ports may have been visible to user space before we torn them back down. In this case there is a slight chance user may have triggered port refresh. We need to make sure the async work is cancelled. We have to cancel after releasing pf->lock, so we will always try to cancel, regardless of which part of probe has failed. Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c index 5f27703..cdd25dc 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c @@ -813,6 +813,7 @@ err_ctrl_unmap: nfp_cpp_area_release_free(pf->data_vnic_bar); err_unlock: mutex_unlock(&pf->lock); + cancel_work_sync(&pf->port_refresh_work); return err; }