From: Bjørn Mork <bjorn@mork.no>
Date: Mon, 8 Mar 2010 12:07:14 +0000 (+0100)
Subject: sdl: improve error message on fatal error
X-Git-Tag: Tizen_Studio_1.3_Release_p2.3.1~5504
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ab82d14dd134bf7c1a4433ccdf1c8d6cd4f0f952;p=sdk%2Femulator%2Fqemu.git

sdl: improve error message on fatal error

The SDL_SetVideoMode() error condition is easily triggered by a user by
simply configure a guest with a host unsupported display resolution
and attempting to enable fullscreen.  Since the error is fatal, adding
a bit of debugging help can't harm.

Sample output with this change:

 (qemu) Could not open SDL display (1280x1024x32): No video mode large enough for 1280x1024

The width x height might seem redundant as SDL also provides it in
SDL_GetError(), but I believe there are situations where it is
useful.  I.e. if there is some other SDL error.  Anyway, redundant
information in fatal error messages has never harmed a single gerbil.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/sdl.c b/sdl.c
index 1d1e1001e6..4c00e9a7eb 100644
--- a/sdl.c
+++ b/sdl.c
@@ -112,7 +112,8 @@ static void do_sdl_resize(int new_width, int new_height, int bpp)
     height = new_height;
     real_screen = SDL_SetVideoMode(width, height, bpp, flags);
     if (!real_screen) {
-        fprintf(stderr, "Could not open SDL display\n");
+	fprintf(stderr, "Could not open SDL display (%dx%dx%d): %s\n", width, 
+		height, bpp, SDL_GetError());
         exit(1);
     }
 }