From: cedric <cedric>
Date: Wed, 30 May 2012 02:19:07 +0000 (+0000)
Subject: eet: properly check buffer size during decipher.
X-Git-Tag: submit/2.0alpha-wayland/20121127.222001~51
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ab808e47fe57531c7ff73197c85c82b8c9f89bf9;p=profile%2Fivi%2Feet.git

eet: properly check buffer size during decipher.

Fix bug #1017.


git-svn-id: http://svn.enlightenment.org/svn/e/trunk/eet@71524 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33
---

diff --git a/ChangeLog b/ChangeLog
index 9df47e5..c862049 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -594,3 +594,7 @@
 2012-05-15  Cedric Bail
 
 	* Make eet_dictionary thread safe.
+
+2012-05-30  Cedric Bail
+
+	* Check that gnutls and openssl don't return below zero size during decipher.
diff --git a/NEWS b/NEWS
index 5d11d3e..f7da97e 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,7 @@ Changes since Eet 1.6.0:
 Fixes:
     * Force destruction of all pending file when shuting down eet.
     * Make eet_dictionary thread safe.
+    * Check that gnutls and openssl don't return below zero size during decipher.
 
 Eet 1.6.0
 
diff --git a/src/lib/eet_cipher.c b/src/lib/eet_cipher.c
index 2425e22..9441d8c 100644
--- a/src/lib/eet_cipher.c
+++ b/src/lib/eet_cipher.c
@@ -1219,7 +1219,7 @@ eet_decipher(const void   *data,
    /* Get the decrypted data size */
    tmp = *ret;
    tmp = ntohl(tmp);
-   if (tmp > tmp_len)
+   if (tmp > tmp_len || tmp <= 0)
      goto on_error;
 
    /* Update the return values */