From: Eric Anholt Date: Wed, 30 Jan 2019 19:17:35 +0000 (-0800) Subject: v3d: Fix image_load_store clamping of signed integer stores. X-Git-Tag: upstream/19.3.0~10111 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ab4d5775b0decad7df56245cecad63912ed62b4c;p=platform%2Fupstream%2Fmesa.git v3d: Fix image_load_store clamping of signed integer stores. This was copy-and-paste fail, that oddly showed up in the CTS's reinterprets of r32f, rgba8, and srgba8 to rgba8i, but not r32ui and r32i to rgba8i or reinterprets to other signed int formats. Fixes: 6281f26f064a ("v3d: Add support for shader_image_load_store.") --- diff --git a/src/broadcom/compiler/v3d_nir_lower_image_load_store.c b/src/broadcom/compiler/v3d_nir_lower_image_load_store.c index e74206b..2aa3cba 100644 --- a/src/broadcom/compiler/v3d_nir_lower_image_load_store.c +++ b/src/broadcom/compiler/v3d_nir_lower_image_load_store.c @@ -156,7 +156,7 @@ pack_sint(nir_builder *b, nir_ssa_def *color, const unsigned *bits, int num_components) { color = nir_channels(b, color, (1 << num_components) - 1); - color = nir_format_clamp_uint(b, color, bits); + color = nir_format_clamp_sint(b, color, bits); return pack_bits(b, color, bits, num_components, true); }