From: hj kim Date: Fri, 21 Jun 2019 08:18:01 +0000 (+0900) Subject: Change internal API to static X-Git-Tag: submit/tizen/20190624.235319^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ab3e5a6394217ee070222e5640c0db73190a1de0;p=platform%2Fcore%2Fapi%2Fmetadata-extractor.git Change internal API to static Change-Id: I2ed4b648d517e0544b95e029625a64f999e0584b --- diff --git a/include/metadata_extractor_private.h b/include/metadata_extractor_private.h old mode 100755 new mode 100644 index fd9a03c..e643ff0 --- a/include/metadata_extractor_private.h +++ b/include/metadata_extractor_private.h @@ -58,7 +58,6 @@ extern "C" { SECURE_LOGI(""fmt"", ##arg); \ } while (0) - #define metadata_extractor_retv_free_if(expr, val, p_str) do { \ if (expr) { \ LOGE("Internal operation error"); \ diff --git a/src/metadata_extractor.c b/src/metadata_extractor.c index 334405b..765b7f5 100644 --- a/src/metadata_extractor.c +++ b/src/metadata_extractor.c @@ -43,22 +43,21 @@ static int __metadata_extractor_destroy_handle(metadata_extractor_s *metadata); static int __metadata_extractor_get_audio_codec(metadata_extractor_s *metadata, char **audio_codec); static int __metadata_extractor_get_video_codec(metadata_extractor_s *metadata, char **video_codec); -int __metadata_extractor_error_capi(int fileinfo_error) +static int __metadata_extractor_error_capi(int fileinfo_error) { - /*Error None*/ - if (fileinfo_error == FILEINFO_ERROR_NONE) + switch (fileinfo_error) { + case FILEINFO_ERROR_NONE: return METADATA_EXTRACTOR_ERROR_NONE; - /*File not found error*/ - if (fileinfo_error == FILEINFO_ERROR_FILE_NOT_FOUND) + case FILEINFO_ERROR_FILE_NOT_FOUND: return METADATA_EXTRACTOR_ERROR_FILE_EXISTS; - /*Permission denied error*/ - else if (fileinfo_error == FILEINFO_ERROR_PERMISSION_DENIED) + case FILEINFO_ERROR_PERMISSION_DENIED: return METADATA_EXTRACTOR_ERROR_PERMISSION_DENIED; - /*ETC*/ - return METADATA_EXTRACTOR_ERROR_OPERATION_FAILED; + default : + return METADATA_EXTRACTOR_ERROR_OPERATION_FAILED; + } } static int __metadata_extractor_check_and_extract_meta(metadata_extractor_s *metadata, metadata_extractor_type_e metadata_type)