From: Dave Airlie <airlied@redhat.com>
Date: Wed, 6 Oct 2021 07:13:46 +0000 (+1000)
Subject: device_select: close dri3 fd after using it.
X-Git-Tag: upstream/22.3.5~16951
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ab1c888c8d6505d17bfd6a1117c5e77d4f4ac337;p=platform%2Fupstream%2Fmesa.git

device_select: close dri3 fd after using it.

This can leak and causes crashes in some CTS test groups
dEQP-VK.wsi.xcb.incremental_present*

Fixes: 9bc5b2d169d3 ("vulkan: add initial device selection layer. (v6.1)")
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13215>
---

diff --git a/src/vulkan/device-select-layer/device_select_x11.c b/src/vulkan/device-select-layer/device_select_x11.c
index 93b39f2..b17402e 100644
--- a/src/vulkan/device-select-layer/device_select_x11.c
+++ b/src/vulkan/device-select-layer/device_select_x11.c
@@ -93,6 +93,7 @@ int device_select_find_xcb_pci_default(struct device_pci_info *devices, uint32_t
 
   drmDevicePtr xdev;
   int ret = drmGetDevice2(dri3_fd, 0, &xdev);
+  close(dri3_fd);
   if (ret < 0)
     goto out;