From: Ville Syrjälä Date: Mon, 4 Nov 2013 19:18:46 +0000 (+0200) Subject: drm/sysfs: Remove stale comments about calling drm_sysfs_connector_add() multiple... X-Git-Tag: v4.0~2657^2~121 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ab13096122903ed9f1b2028674256774b0ce6b59;p=platform%2Fkernel%2Flinux-amlogic.git drm/sysfs: Remove stale comments about calling drm_sysfs_connector_add() multiple times drm_connector_sysfs_add() explicitly checks if connector->kdev is already populated and returns success. So it clearly now allows being called multiple times. Remove some stale comments to the contrary. Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie --- diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index db1c8f9..1a35ea5 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -366,11 +366,6 @@ static struct bin_attribute edid_attr = { * properties (so far, connection status, dpms, mode list & edid) and * generate a hotplug event so userspace knows there's a new connector * available. - * - * Note: - * This routine should only be called *once* for each registered connector. - * A second call for an already registered connector will trigger the BUG_ON - * below. */ int drm_sysfs_connector_add(struct drm_connector *connector) { @@ -383,7 +378,6 @@ int drm_sysfs_connector_add(struct drm_connector *connector) if (connector->kdev) return 0; - /* We shouldn't get called more than once for the same connector */ connector->kdev = device_create(drm_class, dev->primary->kdev, 0, connector, "card%d-%s", dev->primary->index, drm_get_connector_name(connector));