From: Marc Mutz <marc.mutz@kdab.com>
Date: Tue, 28 Feb 2012 21:52:41 +0000 (+0100)
Subject: QRingBuffer: make constructor explicit
X-Git-Tag: qt-v5.0.0-alpha1~684
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aac821c220662ec9d1acbf88ac82603bbda3cee8;p=profile%2Fivi%2Fqtbase.git

QRingBuffer: make constructor explicit

This is a private class, but it's so close to
the classical Stack(int) example for explicit
that I just have to make this ctor explicit,
too:

   QRingBuffer rb = 0; // oops: meant '*rb'

now no longer compiles.

Change-Id: I7d58c1f08c1b14d14930426159c5c8db71b4cf4d
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
---

diff --git a/src/corelib/tools/qringbuffer_p.h b/src/corelib/tools/qringbuffer_p.h
index 46e5050..c248477 100644
--- a/src/corelib/tools/qringbuffer_p.h
+++ b/src/corelib/tools/qringbuffer_p.h
@@ -61,7 +61,7 @@ QT_BEGIN_NAMESPACE
 class QRingBuffer
 {
 public:
-    inline QRingBuffer(int growth = 4096) : basicBlockSize(growth) {
+    explicit inline QRingBuffer(int growth = 4096) : basicBlockSize(growth) {
         buffers << QByteArray();
         clear();
     }