From: Wim Taymans Date: Wed, 31 Jul 2013 15:08:58 +0000 (+0200) Subject: jitterbuffer: small cleanup X-Git-Tag: 1.19.3~509^2~5508 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aa951433eef51e6f5bde3e2ad636d98319ae75d3;p=platform%2Fupstream%2Fgstreamer.git jitterbuffer: small cleanup --- diff --git a/gst/rtpmanager/gstrtpjitterbuffer.c b/gst/rtpmanager/gstrtpjitterbuffer.c index 7bbea0a..2921aac 100644 --- a/gst/rtpmanager/gstrtpjitterbuffer.c +++ b/gst/rtpmanager/gstrtpjitterbuffer.c @@ -1777,6 +1777,11 @@ handle_next_buffer (GstRtpJitterBuffer * jitterbuffer) gint gap; GstRTPBuffer rtp = { NULL, }; + /* only push buffers when PLAYING and active and not buffering */ + if (priv->blocked || !priv->active || + rtp_jitter_buffer_is_buffering (priv->jbuf)) + return GST_FLOW_WAIT; + again: /* peek a buffer, we're just looking at the sequence number. * If all is fine, we'll pop and push it. If the sequence number is wrong we @@ -2065,23 +2070,13 @@ gst_rtp_jitter_buffer_loop (GstRtpJitterBuffer * jitterbuffer) priv = jitterbuffer->priv; JBUF_LOCK_CHECK (priv, flushing); - while (TRUE) { - GST_DEBUG_OBJECT (jitterbuffer, "Peeking item"); - - /* only push buffers when PLAYING and active and not buffering */ - if (!priv->blocked && priv->active && - !rtp_jitter_buffer_is_buffering (priv->jbuf)) - result = handle_next_buffer (jitterbuffer); - else - result = GST_FLOW_WAIT; - - if (result == GST_FLOW_WAIT) { + do { + result = handle_next_buffer (jitterbuffer); + if (G_LIKELY (result == GST_FLOW_WAIT)) /* now wait for the next event */ result = wait_next_timeout (jitterbuffer); - } - if (result != GST_FLOW_OK) - break; } + while (result == GST_FLOW_OK); JBUF_UNLOCK (priv); /* if we get here we need to pause */