From: Qiushi Wu <wu000273@umn.edu>
Date: Thu, 28 May 2020 02:01:09 +0000 (-0500)
Subject: vfio/mdev: Fix reference count leak in add_mdev_supported_type
X-Git-Tag: v5.10.7~2434^2~1^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aa8ba13cae3134b8ef1c1b6879f66372531da738;p=platform%2Fkernel%2Flinux-rpi.git

vfio/mdev: Fix reference count leak in add_mdev_supported_type

kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Thus,
replace kfree() by kobject_put() to fix this issue. Previous
commit "b8eb718348b8" fixed a similar problem.

Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index 8ad14e5..917fd84 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/mdev_sysfs.c
@@ -110,7 +110,7 @@ static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
 				   "%s-%s", dev_driver_string(parent->dev),
 				   group->name);
 	if (ret) {
-		kfree(type);
+		kobject_put(&type->kobj);
 		return ERR_PTR(ret);
 	}