From: Edward Hervey Date: Fri, 8 Dec 2017 07:00:07 +0000 (+0100) Subject: typefind: Avoid overflow calculation (image/quicktime) X-Git-Tag: 1.19.3~511^2~1997 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aa10e82257c4646b18febb0d9dabbc6941f42c08;p=platform%2Fupstream%2Fgstreamer.git typefind: Avoid overflow calculation (image/quicktime) The qt typefinder uses guint64 values for offset and size calculation but the typefinder system only supports gint64 values. Make sure we don't end up using potentially overflowing values. --- diff --git a/gst/typefind/gsttypefindfunctions.c b/gst/typefind/gsttypefindfunctions.c index 0a66e3a..9d8005c 100644 --- a/gst/typefind/gsttypefindfunctions.c +++ b/gst/typefind/gsttypefindfunctions.c @@ -3460,6 +3460,8 @@ qtif_type_find (GstTypeFind * tf, gpointer unused) } offset += size; + if (offset + 8 >= G_MAXINT64) + break; if (++rounds > QTIF_MAXROUNDS) break; }