From: Greg Clayton <gclayton@apple.com>
Date: Thu, 1 Nov 2012 21:35:16 +0000 (+0000)
Subject: Get rid of hack by making the actual call public. This was causing the lldb-platform... 
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aa0c70e38c233226a4c629f0155edba12cd3fd41;p=platform%2Fupstream%2Fllvm.git

Get rid of hack by making the actual call public. This was causing the lldb-platform to not be able to link.

llvm-svn: 167253
---

diff --git a/lldb/include/lldb/API/SBValue.h b/lldb/include/lldb/API/SBValue.h
index 09e0904..7b0a646 100644
--- a/lldb/include/lldb/API/SBValue.h
+++ b/lldb/include/lldb/API/SBValue.h
@@ -413,15 +413,8 @@ public:
     lldb::SBWatchpoint
     WatchPointee (bool resolve_location, bool read, bool write, SBError &error);
 
-    // this must be defined in the .h file because synthetic children as implemented in the core
-    // currently rely on being able to extract the SharedPointer out of an SBValue. if the implementation
-    // is deferred to the .cpp file instead of being inlined here, the platform will fail to link
-    // correctly. however, this is temporary till a better general solution is found. FIXME
     lldb::ValueObjectSP
-    get_sp()
-    {
-        return GetSP();
-    }
+    GetSP () const;
 
 protected:
     friend class SBBlock;
@@ -429,9 +422,6 @@ protected:
     friend class SBThread;
     friend class SBValueList;
 
-    lldb::ValueObjectSP
-    GetSP () const;
-    
     // these calls do the right thing WRT adjusting their settings according to the target's preferences
     void
     SetSP (const lldb::ValueObjectSP &sp);
diff --git a/lldb/source/Interpreter/ScriptInterpreterPython.cpp b/lldb/source/Interpreter/ScriptInterpreterPython.cpp
index ced4645..87c2008 100644
--- a/lldb/source/Interpreter/ScriptInterpreterPython.cpp
+++ b/lldb/source/Interpreter/ScriptInterpreterPython.cpp
@@ -2300,7 +2300,7 @@ ScriptInterpreterPython::GetChildAtIndex (const lldb::ScriptInterpreterObjectSP&
             if (value_sb == NULL)
                 Py_XDECREF(child_ptr);
             else
-                ret_val = value_sb->get_sp();
+                ret_val = value_sb->GetSP();
         }
         else
         {