From: Davidlohr Bueso Date: Wed, 11 Sep 2013 21:25:01 +0000 (-0700) Subject: partitions/efi: compare first and last usable LBAs X-Git-Tag: v3.12-rc1~52^2~56 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aa054bc93743ecce3a27f1655d59674dabc71a54;p=profile%2Fcommon%2Fkernel-common.git partitions/efi: compare first and last usable LBAs When verifying GPT header integrity, make sure that first usable LBA is smaller than last usable LBA. Signed-off-by: Davidlohr Bueso Reviewed-by: Karel Zak Acked-by: Matt Fleming Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/block/partitions/efi.c b/block/partitions/efi.c index b028af6..de9f9bf 100644 --- a/block/partitions/efi.c +++ b/block/partitions/efi.c @@ -410,7 +410,12 @@ static int is_gpt_valid(struct parsed_partitions *state, u64 lba, (unsigned long long)lastlba); goto fail; } - + if (le64_to_cpu((*gpt)->last_usable_lba) < le64_to_cpu((*gpt)->first_usable_lba)) { + pr_debug("GPT: last_usable_lba incorrect: %lld > %lld\n", + (unsigned long long)le64_to_cpu((*gpt)->last_usable_lba), + (unsigned long long)le64_to_cpu((*gpt)->first_usable_lba)); + goto fail; + } /* Check that sizeof_partition_entry has the correct value */ if (le32_to_cpu((*gpt)->sizeof_partition_entry) != sizeof(gpt_entry)) { pr_debug("GUID Partitition Entry Size check failed.\n");