From: Edward Hervey Date: Thu, 22 Oct 2009 11:13:56 +0000 (+0200) Subject: gsturi: Optimisation : Cast when we're sure of the type. X-Git-Tag: RELEASE-0.10.26~315 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a9ed7c0ec4c3a67fb25253463854f6f1a7407edc;p=platform%2Fupstream%2Fgstreamer.git gsturi: Optimisation : Cast when we're sure of the type. Also directly access GstElementFactory->uri_type instead of going through a function that will (once again) check whether it's a GstElementFactory --- diff --git a/gst/gsturi.c b/gst/gsturi.c index d5c301d..ab9c4bb 100644 --- a/gst/gsturi.c +++ b/gst/gsturi.c @@ -495,9 +495,9 @@ search_by_entry (GstPluginFeature * feature, gpointer search_entry) if (!GST_IS_ELEMENT_FACTORY (feature)) return FALSE; - factory = GST_ELEMENT_FACTORY (feature); + factory = GST_ELEMENT_FACTORY_CAST (feature); - if (gst_element_factory_get_uri_type (factory) != entry->type) + if (factory->uri_type != entry->type) return FALSE; protocols = gst_element_factory_get_uri_protocols (factory); @@ -606,7 +606,8 @@ gst_element_make_from_uri (const GstURIType type, const gchar * uri, possibilities = g_list_sort (possibilities, sort_by_rank); walk = possibilities; while (walk) { - if ((ret = gst_element_factory_create (GST_ELEMENT_FACTORY (walk->data), + if ((ret = + gst_element_factory_create (GST_ELEMENT_FACTORY_CAST (walk->data), elementname)) != NULL) { GstURIHandler *handler = GST_URI_HANDLER (ret);