From: Dan Carpenter Date: Wed, 4 Jan 2012 07:20:47 +0000 (+0300) Subject: drm/nv50/pm: signedness bug in nv50_pm_clocks_pre() X-Git-Tag: upstream/snapshot3+hdmi~8206^2~6^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a9d993882008a1ae2c953064f0c2ca7e604b1333;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git drm/nv50/pm: signedness bug in nv50_pm_clocks_pre() calc_mclk() returns zero on success and negative on failure but clk is a u32. v2: Martin Peres: - clk should be an int, not a u32 Signed-off-by: Martin Peres Signed-off-by: Dan Carpenter Signed-off-by: Ben Skeggs --- diff --git a/drivers/gpu/drm/nouveau/nv50_pm.c b/drivers/gpu/drm/nouveau/nv50_pm.c index 0393721..ec5481d 100644 --- a/drivers/gpu/drm/nouveau/nv50_pm.c +++ b/drivers/gpu/drm/nouveau/nv50_pm.c @@ -495,9 +495,9 @@ nv50_pm_clocks_pre(struct drm_device *dev, struct nouveau_pm_level *perflvl) struct drm_nouveau_private *dev_priv = dev->dev_private; struct nv50_pm_state *info; struct pll_lims pll; - int ret = -EINVAL; + int clk, ret = -EINVAL; int N, M, P1, P2; - u32 clk, out; + u32 out; if (dev_priv->chipset == 0xaa || dev_priv->chipset == 0xac)