From: Yongtaek Jeon Date: Tue, 15 Apr 2025 10:04:35 +0000 (+0900) Subject: soc: spacemit: pm_domain: Fix qos remove flag mismatch X-Git-Tag: accepted/tizen/unified/20250428.091728^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a9b54a6dc419a051538ef8ef7073b74e8a8a2433;p=platform%2Fkernel%2Flinux-riscv.git soc: spacemit: pm_domain: Fix qos remove flag mismatch atomic_freq_qos_remove_request() triggered a WARN() due to removal of an inactive request. The condition was based on handle_pm_domain, but the request was added only when handle_cpuidle_qos was true. Use the correct flag to avoid calling remove without add. Change-Id: I24c9e9a5e757abdda275aaa3a10bcb9d87d1c710 Signed-off-by: Yongtaek Jeon --- diff --git a/drivers/soc/spacemit/pm_domain/k1x-pm_domain.c b/drivers/soc/spacemit/pm_domain/k1x-pm_domain.c index b7c10cd2e556..b0e7290de903 100644 --- a/drivers/soc/spacemit/pm_domain/k1x-pm_domain.c +++ b/drivers/soc/spacemit/pm_domain/k1x-pm_domain.c @@ -479,7 +479,7 @@ static void spacemit_pd_detach_dev(struct generic_pm_domain *genpd, struct devic devm_regulator_put(pos->rgr[pos->rgr_count]); } - if (pos->handle_pm_domain) { + if (pos->handle_cpuidle_qos) { atomic_freq_qos_remove_request(&pos->qos); }