From: Paul E. McKenney <paulmck@kernel.org>
Date: Tue, 25 May 2021 18:28:40 +0000 (-0700)
Subject: rcu-tasks: Don't delete holdouts within trc_wait_for_one_reader()
X-Git-Tag: accepted/tizen/unified/20230118.172025~6806^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a9ab9cce9367a2cc02a3c7eb57a004dc0b8f380d;p=platform%2Fkernel%2Flinux-rpi.git

rcu-tasks: Don't delete holdouts within trc_wait_for_one_reader()

Invoking trc_del_holdout() from within trc_wait_for_one_reader() is
only a performance optimization because the RCU Tasks Trace grace-period
kthread will eventually do this within check_all_holdout_tasks_trace().
But it is not a particularly important performance optimization because
it only applies to the grace-period kthread, of which there is but one.
This commit therefore removes this invocation of trc_del_holdout() in
favor of the one in check_all_holdout_tasks_trace() in the grace-period
kthread.

Reported-by: "Xu, Yanfei" <yanfei.xu@windriver.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---

diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index 3d5cb6c..8536c55 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -982,7 +982,6 @@ static void trc_wait_for_one_reader(struct task_struct *t,
 	// The current task had better be in a quiescent state.
 	if (t == current) {
 		t->trc_reader_checked = true;
-		trc_del_holdout(t);
 		WARN_ON_ONCE(t->trc_reader_nesting);
 		return;
 	}