From: Sachin Prabhu Date: Fri, 31 Jan 2014 14:27:16 +0000 (+0000) Subject: cifs: Fix check for regular file in couldbe_mf_symlink() X-Git-Tag: accepted/tizen/common/20141203.182822~636^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a9a315d41407cd1079eb815f4adae897cc08b0d2;p=platform%2Fkernel%2Flinux-arm64.git cifs: Fix check for regular file in couldbe_mf_symlink() MF Symlinks are regular files containing content in a specified format. The function couldbe_mf_symlink() checks the mode for a set S_IFREG bit as a test to confirm that it is a regular file. This bit is also set for other filetypes and simply checking for this bit being set may return false positives. We ensure that we are actually checking for a regular file by using the S_ISREG macro to test instead. Signed-off-by: Sachin Prabhu Reviewed-by: Jeff Layton Reported-by: Neil Brown Reported-by: Dan Carpenter Signed-off-by: Steve French --- diff --git a/fs/cifs/link.c b/fs/cifs/link.c index 52f41f9..264ece7 100644 --- a/fs/cifs/link.c +++ b/fs/cifs/link.c @@ -185,7 +185,7 @@ format_mf_symlink(u8 *buf, unsigned int buf_len, const char *link_str) bool couldbe_mf_symlink(const struct cifs_fattr *fattr) { - if (!(fattr->cf_mode & S_IFREG)) + if (!S_ISREG(fattr->cf_mode)) /* it's not a symlink */ return false;