From: Kim Motoyoshi Kalland Date: Thu, 23 Jun 2011 12:13:24 +0000 (+0200) Subject: Updated tst_nodestest to use the DirtyForceUpdate flag. X-Git-Tag: qt-v5.0.0-alpha1~2170^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a9853d2ffe177bf98eb7610b58bb1bbb44743510;p=profile%2Fivi%2Fqtdeclarative.git Updated tst_nodestest to use the DirtyForceUpdate flag. Changed test to use DirtyForceUpdate instead of DirtyAll, and removed DirtyRenderOrder and DirtyAll enums which should not be used. --- diff --git a/src/declarative/particles/qsgcustomparticle.cpp b/src/declarative/particles/qsgcustomparticle.cpp index 09cfdda..46f160d 100644 --- a/src/declarative/particles/qsgcustomparticle.cpp +++ b/src/declarative/particles/qsgcustomparticle.cpp @@ -452,8 +452,6 @@ QSGShaderEffectNode* QSGCustomParticle::buildCustomNode() if (s.vertexCode.isEmpty()) s.vertexCode = qt_particles_default_vertex_code; m_material.setProgramSource(s); - node->markDirty(QSGNode::DirtyMaterial); - node->markDirty(QSGNode::DirtyAll); return node; } diff --git a/src/declarative/scenegraph/coreapi/qsgnode.cpp b/src/declarative/scenegraph/coreapi/qsgnode.cpp index bfe17ca..b295d25 100644 --- a/src/declarative/scenegraph/coreapi/qsgnode.cpp +++ b/src/declarative/scenegraph/coreapi/qsgnode.cpp @@ -458,9 +458,9 @@ void QSGNode::markDirty(DirtyFlags flags) int geometryCountDiff = 0; if (flags & DirtyNodeAdded) - geometryCountDiff = m_subtreeGeometryCount; + geometryCountDiff += m_subtreeGeometryCount; if (flags & DirtyNodeRemoved) - geometryCountDiff = -m_subtreeGeometryCount; + geometryCountDiff -= m_subtreeGeometryCount; QSGNode *p = m_parent; while (p) { diff --git a/src/declarative/scenegraph/coreapi/qsgnode.h b/src/declarative/scenegraph/coreapi/qsgnode.h index cee6b76..80def63 100644 --- a/src/declarative/scenegraph/coreapi/qsgnode.h +++ b/src/declarative/scenegraph/coreapi/qsgnode.h @@ -82,11 +82,9 @@ public: DirtyNodeAdded = 0x0004, DirtyNodeRemoved = 0x0008, DirtyGeometry = 0x0010, - DirtyRenderOrder = 0x0020, DirtyMaterial = 0x0040, DirtyOpacity = 0x0080, DirtyForceUpdate = 0x0100, - DirtyAll = 0xffff, DirtyPropagationMask = DirtyMatrix | DirtyClipList diff --git a/tests/auto/declarative/node/tst_nodestest.cpp b/tests/auto/declarative/node/tst_nodestest.cpp index a1b0a6a..fc159b9 100644 --- a/tests/auto/declarative/node/tst_nodestest.cpp +++ b/tests/auto/declarative/node/tst_nodestest.cpp @@ -196,14 +196,14 @@ public: if (renderer->rootNode()->parent()) { // Mark the root dirty to build a clean state from the root and down - renderer->rootNode()->markDirty(QSGNode::DirtyAll); + renderer->rootNode()->markDirty(QSGNode::DirtyForceUpdate); } renderer->renderScene(); if (renderer->rootNode()->parent()) { // Mark the parent of the root dirty to force the root and down to be updated. - renderer->rootNode()->parent()->markDirty(QSGNode::DirtyAll); + renderer->rootNode()->parent()->markDirty(QSGNode::DirtyForceUpdate); } }