From: urmain <wn.jang@samsung.com>
Date: Fri, 27 Sep 2024 01:57:12 +0000 (+0900)
Subject: Fix defect detected by static analysis tool
X-Git-Tag: accepted/tizen/unified/20241106.141127~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a93c49c8f320ca84df91861f7dc3cc543f77d5da;p=platform%2Fcore%2Fuifw%2Fmulti-assistant-service.git

Fix defect detected by static analysis tool

Change-Id: I5b90f1bf28d30d16d185deb895c3d508a800123f
---

diff --git a/org.tizen.multi-assistant-service.xml b/org.tizen.multi-assistant-service.xml
index 164b137..3ec4559 100644
--- a/org.tizen.multi-assistant-service.xml
+++ b/org.tizen.multi-assistant-service.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
-<manifest xmlns="http://tizen.org/ns/packages" api-version="5.0" package="org.tizen.multi-assistant-service" version="0.3.40">
+<manifest xmlns="http://tizen.org/ns/packages" api-version="5.0" package="org.tizen.multi-assistant-service" version="0.3.41">
 	<label>Multi Assistant Service</label>
 	<author email="wn.jang@samsung.com" href="www.samsung.com">Won Nam Jang</author>
 	<author email="sooyeon.kim@samsung.com" href="www.samsung.com">Sooyeon Kim</author>
diff --git a/src/client_manager.cpp b/src/client_manager.cpp
index 9bd575b..9d88a1e 100644
--- a/src/client_manager.cpp
+++ b/src/client_manager.cpp
@@ -34,16 +34,11 @@ int CClientManager::create_client(pid_t pid, std::string appid, std::string send
 		return -1;// MA_ERROR_OUT_OF_MEMORY;
 	}
 
-	if (data) {
-		data->pid = pid;
-		data->appid = appid;
-		data->sender_info = sender_info;
-		mClientList = g_slist_append(mClientList, data);
-		MAS_LOGI("Create client : %s %d", appid.c_str(), pid);
-	} else {
-		MAS_LOGE("[ERROR] data is NULL");
-		return -1;// MA_ERROR_OUT_OF_MEMORY;
-	}
+	data->pid = pid;
+	data->appid = appid;
+	data->sender_info = sender_info;
+	mClientList = g_slist_append(mClientList, data);
+	MAS_LOGI("Create client : %s %d", appid.c_str(), pid);
 
 	return 0;
 }