From: Ilya <DieselMachine84@users.noreply.github.com>
Date: Mon, 10 Apr 2017 17:21:41 +0000 (+0300)
Subject: Incorrect parameter order found by PVS-Studio (dotnet/coreclr#10497)
X-Git-Tag: submit/tizen/20210909.063632~11030^2~7334
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a8f53d262bbcc49f14be6f526fc4da5731ce7ac2;p=platform%2Fupstream%2Fdotnet%2Fruntime.git

Incorrect parameter order found by PVS-Studio (dotnet/coreclr#10497)

* Incorrect parameter order found by PVS-Studio
I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the error, detected with the help of V3066 diagnostic https://www.viva64.com/en/w/V3066/

Commit migrated from https://github.com/dotnet/coreclr/commit/0ca41bc62319c16dfafab2767abe623bb4be4547
---

diff --git a/src/coreclr/src/mscorlib/src/System/Reflection/RuntimeModule.cs b/src/coreclr/src/mscorlib/src/System/Reflection/RuntimeModule.cs
index 4e77e8f..75809cb 100644
--- a/src/coreclr/src/mscorlib/src/System/Reflection/RuntimeModule.cs
+++ b/src/coreclr/src/mscorlib/src/System/Reflection/RuntimeModule.cs
@@ -20,7 +20,7 @@ namespace System.Reflection
         #region FCalls
         [DllImport(JitHelpers.QCall, CharSet = CharSet.Unicode)]
         [SuppressUnmanagedCodeSecurity]
-        private extern static void GetType(RuntimeModule module, String className, bool ignoreCase, bool throwOnError, ObjectHandleOnStack type, ObjectHandleOnStack keepAlive);
+        private extern static void GetType(RuntimeModule module, String className, bool throwOnError, bool ignoreCase, ObjectHandleOnStack type, ObjectHandleOnStack keepAlive);
 
         [DllImport(JitHelpers.QCall)]
         [SuppressUnmanagedCodeSecurity]