From: Jesper Juhl Date: Tue, 26 Jun 2012 22:55:37 +0000 (+0200) Subject: drm/i915/sprite: Fix mem leak in intel_plane_init() X-Git-Tag: v3.6-rc1~83^2~39^2~32 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a8b0bbabf756bfb45a712b823ba41f5c95f85589;p=platform%2Fupstream%2Fkernel-adaptation-pc.git drm/i915/sprite: Fix mem leak in intel_plane_init() If we ever hit the default case in the switch statement we'll return from the function without freeing the memory we just allocated to 'intel_plane' (but that has not been used). This patch gets rid of the leak by freeing the memory just before we return. Signed-off-by: Jesper Juhl Reviewed-by: Jesse Barnes Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index b041097..1a1483b 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c @@ -691,6 +691,7 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe) break; default: + kfree(intel_plane); return -ENODEV; } @@ -705,4 +706,3 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe) return ret; } -