From: Pádraig Brady <P@draigBrady.com>
Date: Mon, 7 Sep 2009 22:50:19 +0000 (+0100)
Subject: tests: address a race condition in misc/cat-buf
X-Git-Tag: v7.6~9
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a863644397a66308d60464bace26da857f494f8c;p=platform%2Fupstream%2Fcoreutils.git

tests: address a race condition in misc/cat-buf

* tests/misc/cat-buf: Increase the delay between writes
to decrease the chance that dd will read both at once.
Since the test is inherently racy, print a warning via
skip_test_ rather than failing outright.
Reported by Jim Meyering.
---

diff --git a/tests/misc/cat-buf b/tests/misc/cat-buf
index d37f9f4..11d553a 100755
--- a/tests/misc/cat-buf
+++ b/tests/misc/cat-buf
@@ -30,12 +30,17 @@ fi
 # write separately.
 mkfifo fifo || framework_failure
 
+fail=0
+
 echo 1 > exp
 
 dd count=1 if=fifo > out &
-(echo 1; sleep .2; echo 2) | cat -v > fifo
+(echo 1; sleep .5; echo 2) | cat -v > fifo
 wait # for dd to complete
 
-compare out exp || fail=1
+# Though unlikely, this test may fail because dd was starved
+# between opening the fifo and reading from it until after the
+# second echo.  So ask to double check rather than failing.
+compare out exp || skip_test_ "possible test failure. Please verify."
 
 Exit $fail