From: Peter Maydell Date: Wed, 9 Nov 2011 17:42:23 +0000 (+0000) Subject: hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes X-Git-Tag: TizenStudio_2.0_p2.3~1983 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a7e7dc62fb4a652cfe47e544c0d8384c574b9321;p=sdk%2Femulator%2Fqemu.git hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes Add missing 'break' statements which would have meant that writing to an 8 bit NAND device was broken. Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell Signed-off-by: Anthony Liguori --- diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c index 7fc82a2..414f9f5 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -180,6 +180,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value, nand_setio(dev, (value >> 24) & 0xff); break; } + break; case OMAP_GPMC_16BIT: switch (size) { case 1: @@ -195,6 +196,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value, nand_setio(dev, (value >> 16) & 0xffff); break; } + break; } }