From: Piotr Kosko
Date: Wed, 4 Nov 2015 13:09:41 +0000 (+0100)
Subject: Revert "[Download] Privilege checks moved to JS."
X-Git-Tag: submit/tizen_mobile/20151215.080542^2~13
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a7d7075ee59bdefac89740cbe84f56adb3074aa1;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git
Revert "[Download] Privilege checks moved to JS."
This reverts commit 5b89c87afbebbe3963f5e242d94cf2209e469522.
[Verification] TCT passrate is 100%
Change-Id: I5aea86a5d6ee6308bda5af9eecf2c91b5d4a0ea9
Signed-off-by: Piotr Kosko
---
diff --git a/src/download/download_api.js b/src/download/download_api.js
index 841423ed..018bfca2 100755
--- a/src/download/download_api.js
+++ b/src/download/download_api.js
@@ -180,8 +180,6 @@ function DownloadManager() {
}
DownloadManager.prototype.start = function() {
- xwalk.utils.checkPrivilegeAccess(xwalk.utils.privilege.DOWNLOAD);
-
var args = validator_.validateArgs(arguments, [
{'name' : 'downloadRequest', 'type': types_.PLATFORM_OBJECT, 'values': tizen.DownloadRequest},
{'name' : 'downloadCallback', 'type': types_.LISTENER,
diff --git a/src/download/download_instance.cc b/src/download/download_instance.cc
index 4ed7c6e5..24602d65 100755
--- a/src/download/download_instance.cc
+++ b/src/download/download_instance.cc
@@ -32,6 +32,12 @@ namespace download {
std::vector DownloadInstance::instances_;
std::mutex DownloadInstance::instances_mutex_;
+namespace {
+// The privileges that required in Download API
+const std::string kPrivilegeDownload = "http://tizen.org/privilege/download";
+
+} // namespace
+
DownloadInstance::DownloadInstance() {
LoggerD("Entered");
using std::placeholders::_1;
@@ -425,6 +431,7 @@ void DownloadInstance::progress_changed_cb
void DownloadInstance::DownloadManagerStart
(const picojson::value& args, picojson::object& out) {
LoggerD("Entered");
+ CHECK_PRIVILEGE_ACCESS(kPrivilegeDownload, &out);
CHECK_EXIST(args, "callbackId", out)
int ret;