From: Marshall Clow Date: Wed, 7 Sep 2016 03:32:06 +0000 (+0000) Subject: Fix PR#30303 - no matching function for call to '__ptr_in_range' X-Git-Tag: llvmorg-4.0.0-rc1~10492 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a77bb8ef3482cd9dfa0d5631f99c55f5981ba6ca;p=platform%2Fupstream%2Fllvm.git Fix PR#30303 - no matching function for call to '__ptr_in_range' llvm-svn: 280779 --- diff --git a/libcxx/include/string b/libcxx/include/string index cfae0c8..b9e044e 100644 --- a/libcxx/include/string +++ b/libcxx/include/string @@ -2156,12 +2156,18 @@ basic_string<_CharT, _Traits, _Allocator>::append(_InputIterator __first, _Input return *this; } -template +template bool __ptr_in_range (const _Tp* __p, const _Tp* __first, const _Tp* __last) { return __first <= __p && __p < __last; } +template +bool __ptr_in_range (const _Tp1* __p, const _Tp2* __first, const _Tp2* __last) +{ + return false; +} + template template typename enable_if diff --git a/libcxx/test/std/strings/basic.string/string.modifiers/string_append/iterator.pass.cpp b/libcxx/test/std/strings/basic.string/string.modifiers/string_append/iterator.pass.cpp index 8c54a38..e834c1b 100644 --- a/libcxx/test/std/strings/basic.string/string.modifiers/string_append/iterator.pass.cpp +++ b/libcxx/test/std/strings/basic.string/string.modifiers/string_append/iterator.pass.cpp @@ -195,4 +195,13 @@ int main() assert(s_long == "Lorem ipsum dolor sit amet, consectetur/Lorem ipsum dolor sit amet, consectetur/"); } + { // test appending a different type + typedef std::string S; + const uint8_t p[] = "ABCD"; + + S s; + s.append(p, p + 4); + assert(s == "ABCD"); + } + } diff --git a/libcxx/test/std/strings/basic.string/string.modifiers/string_assign/iterator.pass.cpp b/libcxx/test/std/strings/basic.string/string.modifiers/string_assign/iterator.pass.cpp index 0d3dac7..20e242d 100644 --- a/libcxx/test/std/strings/basic.string/string.modifiers/string_assign/iterator.pass.cpp +++ b/libcxx/test/std/strings/basic.string/string.modifiers/string_assign/iterator.pass.cpp @@ -196,4 +196,13 @@ int main() s_long.assign(s_long.begin() + 30, s_long.end()); assert(s_long == "nsectetur/"); } + + { // test assigning a different type + typedef std::string S; + const uint8_t p[] = "ABCD"; + + S s; + s.assign(p, p + 4); + assert(s == "ABCD"); + } } diff --git a/libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp b/libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp index 1b5baf4..9803d5a 100644 --- a/libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp +++ b/libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp @@ -186,4 +186,12 @@ int main() assert(s_long == "Lorem ipsum dolor sit amet, consectetur/Lorem ipsum dolor sit amet, consectetur/"); } + { // test assigning a different type + typedef std::string S; + const uint8_t p[] = "ABCD"; + + S s; + s.insert(s.begin(), p, p + 4); + assert(s == "ABCD"); + } } diff --git a/libcxx/test/std/strings/basic.string/string.modifiers/string_replace/iter_iter_iter_iter.pass.cpp b/libcxx/test/std/strings/basic.string/string.modifiers/string_replace/iter_iter_iter_iter.pass.cpp index abf1521..1231af8 100644 --- a/libcxx/test/std/strings/basic.string/string.modifiers/string_replace/iter_iter_iter_iter.pass.cpp +++ b/libcxx/test/std/strings/basic.string/string.modifiers/string_replace/iter_iter_iter_iter.pass.cpp @@ -1023,4 +1023,18 @@ int main() s_long.replace(s_long.begin(), s_long.begin(), s_long.begin(), s_long.end()); assert(s_long == "Lorem ipsum dolor sit amet, consectetur/Lorem ipsum dolor sit amet, consectetur/"); } + + { // test assigning a different type + typedef std::string S; + const uint8_t pc[] = "ABCD"; + uint8_t p[] = "EFGH"; + + S s; + s.replace(s.begin(), s.end(), pc, pc + 4); + assert(s == "ABCD"); + + s.clear(); + s.replace(s.begin(), s.end(), p, p + 4); + assert(s == "EFGH"); + } }