From: Doyoun Kang Date: Tue, 3 Jul 2018 06:57:14 +0000 (+0900) Subject: e_info_server: fix out-of-bounds-write issue X-Git-Tag: submit/tizen_4.0/20180703.081422~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a75df8be02c3a704c3e087d3ac6b81b43dc73b6c;p=platform%2Fupstream%2Fenlightenment.git e_info_server: fix out-of-bounds-write issue Change-Id: I0f973d8107fcb4f5e2558bc8301409eaf51f7414 --- diff --git a/src/bin/e_info_server.c b/src/bin/e_info_server.c index 67eae24bb1..30314adac6 100644 --- a/src/bin/e_info_server.c +++ b/src/bin/e_info_server.c @@ -2602,6 +2602,7 @@ _e_info_server_cb_eina_log_levels(const Eldbus_Service_Interface *iface EINA_UNU { Eldbus_Message *reply = eldbus_message_method_return_new(msg); const char *start = NULL; + int len = 0; if (!eldbus_message_arguments_get(msg, "s", &start) || !start) { @@ -2626,8 +2627,9 @@ _e_info_server_cb_eina_log_levels(const Eldbus_Service_Interface *iface EINA_UNU goto parse_end; // Parse name - strncpy(module_name, start, MIN(end - start, (sizeof module_name) - 1)); - module_name[end - start] = '\0'; + len = MIN(end - start, (sizeof module_name) - 1); + strncpy(module_name, start, len); + module_name[len] = '\0'; eina_log_domain_level_set((const char*)module_name, level);