From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 10 Feb 2015 14:12:59 +0000 (+0100)
Subject: vl: Avoid qerror_report_err() outside QMP command handlers
X-Git-Tag: Tizen_Studio_1.3_Release_p2.3.2~209^2~339^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a720a390b1b2260d245bcc96923bf17e186b4b7e;p=sdk%2Femulator%2Fqemu.git

vl: Avoid qerror_report_err() outside QMP command handlers

qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP.  It should not be used
elsewhere.  Replace by error_report_err() in initial startup helpers
machine_set_property() and object_create().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---

diff --git a/vl.c b/vl.c
index 1e9aff6659..2a58c6b83e 100644
--- a/vl.c
+++ b/vl.c
@@ -2581,8 +2581,7 @@ static int machine_set_property(const char *name, const char *value,
     g_free(qom_name);
 
     if (local_err) {
-        qerror_report_err(local_err);
-        error_free(local_err);
+        error_report_err(local_err);
         return -1;
     }
 
@@ -2635,8 +2634,7 @@ out:
     g_free(type);
     g_free(dummy);
     if (err) {
-        qerror_report_err(err);
-        error_free(err);
+        error_report_err(err);
         return -1;
     }
     return 0;