From: Marek Vasut Date: Tue, 22 Mar 2011 12:09:50 +0000 (+0100) Subject: ARM: pxafb: Fix access to nonexistent member of pxafb_info X-Git-Tag: upstream/snapshot3+hdmi~10530^2~14^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a6d710fefd1b2c209353a452d0f4c831b3af0da0;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ARM: pxafb: Fix access to nonexistent member of pxafb_info In case CONFIG_FB_PXA_OVERLAY is not defined, the pxafb_freq_transition() function tests nonexistent member of pxafb_info (since the member is not part of the structure). Fix this by wraping the test in ifdef, even if I don't really like how the code looks now. The check doesn't have to happen if overlays are disabled at all as the check is always true then. Signed-off-by: Marek Vasut Acked-by: Vasily Khoruzhick Signed-off-by: Eric Miao --- diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c index a2e5b51..0f4e8c9 100644 --- a/drivers/video/pxafb.c +++ b/drivers/video/pxafb.c @@ -1648,7 +1648,9 @@ pxafb_freq_transition(struct notifier_block *nb, unsigned long val, void *data) switch (val) { case CPUFREQ_PRECHANGE: - if (!fbi->overlay[0].usage && !fbi->overlay[1].usage) +#ifdef CONFIG_FB_PXA_OVERLAY + if (!(fbi->overlay[0].usage || fbi->overlay[1].usage)) +#endif set_ctrlr_state(fbi, C_DISABLE_CLKCHANGE); break;