From: chakradhar <v.pogiri@samsung.com>
Date: Sat, 16 Feb 2019 15:27:24 +0000 (+0530)
Subject: svace issues
X-Git-Tag: accepted/tizen/unified/20190218.064124^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a67bc5cbf462b6da98338eb4b181559f03f70c68;p=platform%2Fcore%2Fmessaging%2Femail-service.git

svace issues

Change-Id: Ibdc5ec2d410908a19d9229842b28ac2105b7ea1a
---

diff --git a/email-core/email-storage/email-storage.c b/email-core/email-storage/email-storage.c
index 12c0914..4e5a764 100755
--- a/email-core/email-storage/email-storage.c
+++ b/email-core/email-storage/email-storage.c
@@ -6596,7 +6596,7 @@ INTERNAL_FUNC int emstorage_get_count_read_mail_uid(char *multi_user_name, int a
 	EM_DEBUG_FUNC_BEGIN("account_id[%d], mailbox_name[%p], count[%p], transaction[%d], err_code[%p]", account_id, mailbox_name , count,  transaction, err_code);
 
 	if (account_id < FIRST_ACCOUNT_ID || !mailbox_name || !count) {
-		EM_DEBUG_EXCEPTION(" account_id[%d], mailbox_name[%s], count[%d] ", account_id, mailbox_name, *count);
+		EM_DEBUG_EXCEPTION("Invalid params");
 
 		if (err_code != NULL)
 			*err_code = EMAIL_ERROR_INVALID_PARAM;
@@ -17809,6 +17809,8 @@ static  int emstorage_create_renamed_table(char *multi_user_name, char **input_f
 	int rc = -1;
 	sqlite3 *local_db_handle = NULL;
 	char sql_query_string[QUERY_SIZE] = {0, };
+	
+	local_db_handle = emstorage_get_db_connection(multi_user_name);
 
 	if (input_full_query == NULL || input_source_table_name == NULL || input_new_table_name == NULL) {
 		EM_DEBUG_EXCEPTION("EMAIL_ERROR_INVALID_PARAM");
@@ -17816,8 +17818,6 @@ static  int emstorage_create_renamed_table(char *multi_user_name, char **input_f
 		goto FINISH_OFF;
 	}
 
-	local_db_handle = emstorage_get_db_connection(multi_user_name);
-
 	EMSTORAGE_PROTECTED_FUNC_CALL(sqlite3_exec(local_db_handle, "BEGIN;", NULL, NULL, NULL), rc);
 	EM_DEBUG_DB_EXEC(SQLITE_OK != rc, {goto FINISH_OFF; }, ("SQL(BEGIN EXCLUSIVE) exec fail:%d -%s", rc, sqlite3_errmsg(local_db_handle)));
 
@@ -17849,14 +17849,14 @@ static int emstorage_add_column(char *multi_user_name, char *input_table_name, e
 	sqlite3 *local_db_handle = NULL;
 	char sql_query_string[QUERY_SIZE] = {0, };
 
+	local_db_handle = emstorage_get_db_connection(multi_user_name);
+
 	if (input_table_name == NULL || input_new_column == NULL) {
 		EM_DEBUG_EXCEPTION("EMAIL_ERROR_INVALID_PARAM");
 		error = EMAIL_ERROR_INVALID_PARAM;
 		goto FINISH_OFF;
 	}
 
-	local_db_handle = emstorage_get_db_connection(multi_user_name);
-
 	EMSTORAGE_PROTECTED_FUNC_CALL(sqlite3_exec(local_db_handle, "BEGIN;", NULL, NULL, NULL), rc);
 	EM_DEBUG_DB_EXEC(SQLITE_OK != rc, {goto FINISH_OFF; }, ("SQL(BEGIN EXCLUSIVE) exec fail:%d -%s", rc, sqlite3_errmsg(local_db_handle)));
 	SNPRINTF(sql_query_string, QUERY_SIZE, "ALTER TABLE %s ADD COLUMN %s %s;", input_table_name, input_new_column->column_name, input_new_column->column_type);
@@ -17883,14 +17883,14 @@ static int emstorage_drop_table(char *multi_user_name, char *input_table_name)
 	sqlite3 *local_db_handle = NULL;
 	char sql_query_string[QUERY_SIZE] = {0, };
 
+	local_db_handle = emstorage_get_db_connection(multi_user_name);
+
 	if (input_table_name == NULL) {
 		EM_DEBUG_EXCEPTION("EMAIL_ERROR_INVALID_PARAM");
 		error = EMAIL_ERROR_INVALID_PARAM;
 		goto FINISH_OFF;
 	}
 
-	local_db_handle = emstorage_get_db_connection(multi_user_name);
-
 	EMSTORAGE_PROTECTED_FUNC_CALL(sqlite3_exec(local_db_handle, "BEGIN;", NULL, NULL, NULL), rc);
 	EM_DEBUG_DB_EXEC(SQLITE_OK != rc, {goto FINISH_OFF; }, ("SQL(BEGIN EXCLUSIVE) exec fail:%d -%s", rc, sqlite3_errmsg(local_db_handle)));
 	SNPRINTF(sql_query_string, QUERY_SIZE, "DROP TABLE %s;", input_table_name);