From: Yunmi Ha <yunmi.ha@samsung.com>
Date: Fri, 27 Dec 2019 08:32:31 +0000 (+0900)
Subject: Remove 'format-truncation' warning for GCC-9
X-Git-Tag: submit/tizen/20200103.083647^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a57c5f01be052d85a4f3f99223239a69abecd6bf;p=platform%2Fcore%2Fsystem%2Flibstorage.git

Remove 'format-truncation' warning for GCC-9

Change-Id: I561072c619f169309d66dde7a1946664b8d55935
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
---

diff --git a/src/storage.c b/src/storage.c
index 314f622..6778dff 100644
--- a/src/storage.c
+++ b/src/storage.c
@@ -218,8 +218,12 @@ API int storage_get_directory(int storage_id, storage_directory_e type, char **p
 				*end = '\0';
 			snprintf(temp, PATH_MAX, "%s", temp2);
 			free(temp2);
-		} else
-			snprintf(temp, PATH_MAX, "%s/%s", root, dir_path[type]);
+		} else {
+			if ((ret = snprintf(temp, PATH_MAX, "%s/%s", root, dir_path[type])) > PATH_MAX - 1) {
+				_E("Path is longer than buffer. Need %d size of buffer.", ret + 1);
+				return STORAGE_ERROR_OUT_OF_MEMORY;
+			}
+		}
 
 		goto out;
 	}
@@ -249,7 +253,10 @@ API int storage_get_directory(int storage_id, storage_directory_e type, char **p
 	if (extendedint)
 		return STORAGE_ERROR_INVALID_PARAMETER;
 
-	snprintf(temp, sizeof(temp), "%s/%s", root, dir_path[type]);
+	if ((ret = snprintf(temp, sizeof(temp), "%s/%s", root, dir_path[type])) > sizeof(temp) - 1) {
+		_E("Path is longer than buffer. Need %d size of buffer.", ret + 1);
+		return STORAGE_ERROR_OUT_OF_MEMORY;
+	}
 
 out:
 	*path = strdup(temp);