From: Michał Mirosław Date: Wed, 12 Aug 2020 01:31:38 +0000 (+0200) Subject: regulator: remove superfluous lock in regulator_resolve_coupling() X-Git-Tag: v5.10.7~1600^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a577f3456c0a2fac3dee037c483753e6e68f3e49;p=platform%2Fkernel%2Flinux-rpi.git regulator: remove superfluous lock in regulator_resolve_coupling() The code modifies rdev, but locks c_rdev instead. Remove the lock as this is held together by regulator_list_mutex taken in the caller. Fixes: f9503385b187 ("regulator: core: Mutually resolve regulators coupling") Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Link: https://lore.kernel.org/r/25eb81cefb37a646f3e44eaaf1d8ae8881cfde52.1597195321.git.mirq-linux@rere.qmqm.pl Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 6e2e747..6789d1e 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4972,13 +4972,9 @@ static void regulator_resolve_coupling(struct regulator_dev *rdev) return; } - regulator_lock(c_rdev); - c_desc->coupled_rdevs[i] = c_rdev; c_desc->n_resolved++; - regulator_unlock(c_rdev); - regulator_resolve_coupling(c_rdev); } }