From: Tuomas Tynkkynen Date: Thu, 25 Jul 2013 19:24:09 +0000 (+0300) Subject: usb: phy: tegra: Use switch instead of if-else X-Git-Tag: upstream/snapshot3+hdmi~4476^2~77^2~38 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a554aea67aaadb7f3396b2a8f940ab0b915b2a5e;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git usb: phy: tegra: Use switch instead of if-else Use switch() instead of if-else when checking for the PHY type. Signed-off-by: Tuomas Tynkkynen Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 01c30ff..49fa2da 100644 --- a/drivers/usb/phy/phy-tegra-usb.c +++ b/drivers/usb/phy/phy-tegra-usb.c @@ -887,11 +887,14 @@ static int tegra_usb_phy_probe(struct platform_device *pdev) of_property_read_bool(np, "nvidia,has-legacy-mode"); phy_type = of_usb_get_phy_mode(np); - if (phy_type == USBPHY_INTERFACE_MODE_UTMI) { + switch (phy_type) { + case USBPHY_INTERFACE_MODE_UTMI: err = utmi_phy_probe(tegra_phy, pdev); if (err < 0) return err; - } else if (phy_type == USBPHY_INTERFACE_MODE_ULPI) { + break; + + case USBPHY_INTERFACE_MODE_ULPI: tegra_phy->is_ulpi_phy = true; tegra_phy->reset_gpio = @@ -902,7 +905,9 @@ static int tegra_usb_phy_probe(struct platform_device *pdev) return tegra_phy->reset_gpio; } tegra_phy->config = NULL; - } else { + break; + + default: dev_err(&pdev->dev, "phy_type is invalid or unsupported\n"); return -EINVAL; }