From: Lars Ellenberg Date: Wed, 26 Sep 2012 12:16:30 +0000 (+0200) Subject: drbd: use list_move_tail instead of list_del/list_add_tail X-Git-Tag: v3.8-rc1~78^2~18^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a506c13a4d1ec5e1f2f9bc0123dacb5d123004d3;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git drbd: use list_move_tail instead of list_del/list_add_tail Using list_move_tail() instead of list_del() + list_add_tail(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c index eeda8b8..377f27b 100644 --- a/drivers/block/drbd/drbd_worker.c +++ b/drivers/block/drbd/drbd_worker.c @@ -134,8 +134,7 @@ static void drbd_endio_write_sec_final(struct drbd_peer_request *peer_req) __rel spin_lock_irqsave(&mdev->tconn->req_lock, flags); mdev->writ_cnt += peer_req->i.size >> 9; - list_del(&peer_req->w.list); /* has been on active_ee or sync_ee */ - list_add_tail(&peer_req->w.list, &mdev->done_ee); + list_move_tail(&peer_req->w.list, &mdev->done_ee); /* * Do not remove from the write_requests tree here: we did not send the