From: Lars-Peter Clausen <lars@metafoo.de>
Date: Wed, 4 Jul 2012 16:09:00 +0000 (+0100)
Subject: staging:iio:adt7310: Do not return error code in interrupt handler
X-Git-Tag: v3.6-rc1~100^2~298^2~14
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a4eef3057dff597099673c42f8e3d0455deb9fe1;p=platform%2Fkernel%2Flinux-3.10.git

staging:iio:adt7310: Do not return error code in interrupt handler

The interrupt handler should only ever return one of the three irqreturn_t
constants and not an error code. Also make sure to always call
iio_trigger_notify_done before leaving the trigger handler.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/staging/iio/adc/adt7310.c b/drivers/staging/iio/adc/adt7310.c
index 44dcf63..72460b6 100644
--- a/drivers/staging/iio/adc/adt7310.c
+++ b/drivers/staging/iio/adc/adt7310.c
@@ -397,7 +397,7 @@ static irqreturn_t adt7310_event_handler(int irq, void *private)
 
 	ret = adt7310_spi_read_byte(chip, ADT7310_STATUS, &status);
 	if (ret)
-		return ret;
+		goto done;
 
 	if (status & ADT7310_STAT_T_HIGH)
 		iio_push_event(indio_dev,
@@ -417,6 +417,8 @@ static irqreturn_t adt7310_event_handler(int irq, void *private)
 						    IIO_EV_TYPE_THRESH,
 						    IIO_EV_DIR_RISING),
 			timestamp);
+
+done:
 	return IRQ_HANDLED;
 }