From: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date: Mon, 12 Feb 2018 13:33:49 +0000 (+0200)
Subject: adder: remove non-interleaved layout from caps
X-Git-Tag: 1.19.3~511^2~1589
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=a498d3fe6e2bedd2e1622bb51811d44c8fabd6ed;p=platform%2Fupstream%2Fgstreamer.git

adder: remove non-interleaved layout from caps

adder needs more than just trivial work to support planar buffers properly
because it currently reads sub-buffers from GstCollectPads in order for all
of them to have matching sizes. In planar mode, this means it would truncate
some channels and mix them up in strange ways. It only works if all input
buffers in all sink pads have matching sizes.
---

diff --git a/gst/adder/gstadder.c b/gst/adder/gstadder.c
index dce05f6..f73b6db 100644
--- a/gst/adder/gstadder.c
+++ b/gst/adder/gstadder.c
@@ -167,11 +167,11 @@ enum
 #if G_BYTE_ORDER == G_LITTLE_ENDIAN
 #define CAPS \
   GST_AUDIO_CAPS_MAKE ("{ S32LE, U32LE, S16LE, U16LE, S8, U8, F32LE, F64LE }") \
-  ", layout = (string) { interleaved, non-interleaved }"
+  ", layout = (string) { interleaved }"
 #else
 #define CAPS \
   GST_AUDIO_CAPS_MAKE ("{ S32BE, U32BE, S16BE, U16BE, S8, U8, F32BE, F64BE }") \
-  ", layout = (string) { interleaved, non-interleaved }"
+  ", layout = (string) { interleaved }"
 #endif
 
 static GstStaticPadTemplate gst_adder_src_template =